Skip to content

[SPARK-44998] Do not retry when FileNotFoundException occurs #42711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wForget wants to merge 1 commit into from
Closed

[SPARK-44998] Do not retry when FileNotFoundException occurs #42711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock)
}
} catch {
case _: FileNotFoundException =>
logWarning(s"Log file ${attempt.logPath} not found.")
return None
}

Expand Down Expand Up @@ -1265,6 +1266,10 @@ private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock)
rebuildAppStore(store, reader, attempt.info.lastUpdated.getTime())
hybridStore = store
} catch {
case f: FileNotFoundException =>
store.close()
memoryManager.release(appId, attempt.info.attemptId)
throw f
case _: IOException if !retried =>
// compaction may touch the file(s) which app rebuild wants to read
// compaction wouldn't run in short interval, so try again...
Expand Down Expand Up @@ -1333,6 +1338,10 @@ private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock)
}
newStorePath = lease.commit(appId, attempt.info.attemptId)
} catch {
case f: FileNotFoundException =>
lease.rollback()
throw f

case _: IOException if !retried =>
// compaction may touch the file(s) which app rebuild wants to read
// compaction wouldn't run in short interval, so try again...
Expand Down Expand Up @@ -1360,6 +1369,9 @@ private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock)
rebuildAppStore(s, reader, attempt.info.lastUpdated.getTime())
store = s
} catch {
case f: FileNotFoundException =>
throw f

case _: IOException if !retried =>
// compaction may touch the file(s) which app rebuild wants to read
// compaction wouldn't run in short interval, so try again...
Expand Down