[SPARK-44987][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1100
#42737
Conversation
| }, | ||
| "NON_FOLDABLE_ARGUMENT" : { | ||
| "message" : [ | ||
| "The function <funcName> requires the parameter <paramName> to be a foldable expression of the type <paramType>, but the actual argument is a non-foldable." |
There was a problem hiding this comment.
I'm a bit concerned, does the user know what is foldable and what is non-foldable?
There was a problem hiding this comment.
How would you improve the error message?
There was a problem hiding this comment.
After thinking about it, I really didn't find a better way to express it.😂
There was a problem hiding this comment.
Ya, in this case, new message looks reasonable to me. :)
|
@dongjoon-hyun @HyukjinKwon Could you review this PR, please. |
|
Sure, @MaxGekk . |
|
|
||
| ### NON_FOLDABLE_ARGUMENT | ||
|
|
||
| [SQLSTATE: 22024](sql-error-conditions-sqlstates.html#class-22-data-exception) |
There was a problem hiding this comment.
Data exception category is also reasonable to me if there is no other proper one.
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @MaxGekk .
|
Merging to master. Thank you, @dongjoon-hyun and @Hisoka-X for review. |
3 participants
What changes were proposed in this pull request?
In the PR, I propose to assign the name
NON_FOLDABLE_ARGUMENTto the legacy error class_LEGACY_ERROR_TEMP_1100, and improve the error message format: make it less restrictive.Why are the changes needed?
Does this PR introduce any user-facing change?
No. Only if user's code depends on error class name and message parameters.
How was this patch tested?
By running the modified and affected tests:
Was this patch authored or co-authored using generative AI tooling?
No.