[SPARK-45120][UI] Upgrade d3 from v3 to v7(v7.8.5) and apply api changes in UI #42879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
|
While you're at it, lets put the latest d3 license text from https://github.com/d3/d3/blob/main/LICENSE into https://github.com/apache/spark/blob/master/licenses-binary/LICENSE-d3.min.js.txt and also https://github.com/apache/spark/blob/master/licenses/LICENSE-d3.min.js.txt |
Member
Author
|
Thank you very much @srowen for the reminder. I also updated LICENSE* files |
Member
Author
|
thanks @srowen for the review, merged to master |
Contributor
|
After this PR is merged, the ChromeUISeleniumSuite will fail in testing. after revert this one , the test passed |
Member
Author
|
I will take a look |
Member
|
Let's revert this for now. Seems like this causing a regression for some reasons by breaking the graphs ... (see all truncated under AQE execution). I think we should sort of thoroughly test them since we don't have a lot of tests for UI ... |
Member
Author
|
Hi, @HyukjinKwon the given example seems not to be a spark view? |
Member
|
Oh the graphs are the same ones. Let me try to reproduce in pure OSS Spark. In any event, seems like testing fails: #42879 (comment) |
Member
|
For now, please ignore it. I will try to get a reproducer |
yaooqinn
added a commit
that referenced
this pull request
Sep 14, 2023
…pply api changes in UI ### What changes were proposed in this pull request? This PR is a follow-up of SPARK-45120 to cover the missing cases, and then fix test failures reported by SPARK-45150 It also brings back #42879 ### Why are the changes needed? bugfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? tested with the excluded CI tests bellow ``` [info] ChromeUISeleniumSuite: Starting ChromeDriver 117.0.5938.62 (25a7172909a4cba7355365cf424d7d7eb35231f4-refs/branch-heads/5938{#1146}) on port 12624 Only local connections are allowed. Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe. ChromeDriver was started successfully. [info] - SPARK-31534: text for tooltip should be escaped (1 second, 979 milliseconds) [info] - SPARK-31882: Link URL for Stage DAGs should not depend on paged table. (683 milliseconds) [info] - SPARK-31886: Color barrier execution mode RDD correctly (304 milliseconds) [info] - Search text for paged tables should not be saved (1 second, 307 milliseconds) [info] Run completed in 6 seconds, 702 milliseconds. [info] Total number of tests run: 4 [info] Suites: completed 1, aborted 0 [info] Tests: succeeded 4, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. ```` ### Was this patch authored or co-authored using generative AI tooling? no Closes #42907 from yaooqinn/SPARK-45150. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR upgrades d3 from v3 to v7(v7.8.5).
This PR also applies the API changes to our UI drawing. The related changes are listed below:
d3.transfromselection.on("mousemove", function(d) {
… do something with d3.event and d…
})
becomes:
selection.on("mousemove", function(event, d) {
… do something with event and d …
})
Most of these changes come from v4 and v6, a full list of changes can be found at https://github.com/d3/d3/blob/main/CHANGES.md
Why are the changes needed?
d3 v3 is very old(Feb 11, 2015), deprecated by some of its downstream that we depends on
Does this PR introduce any user-facing change?
no
How was this patch tested?
This PR was locally tested with
org.apache.spark.examples.streaming.SqlNetworkWordCountStreaming page loading
SQL page loading
Was this patch authored or co-authored using generative AI tooling?
no