[SPARK-45899][CONNECT] Set errorClass in errorInfoToThrowable #43772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@HyukjinKwon Please take a look |
heyihong
changed the title
HyukjinKwon
approved these changes
Nov 12, 2023
Member
|
Merged to master. |
MaxGekk
reviewed
Dec 23, 2023
| .setMessage(message) | ||
| .addAllErrorTypeHierarchy(classes.toImmutableArraySeq.asJava) | ||
| .build())) | ||
| .setErrorClass(errorClass) |
Member
There was a problem hiding this comment.
Just set an error class and don't set message parameters doesn't make any sense. The errorClass is just a "type", it is impossible to create an object SparkThrowable without parameters. The message above is a hole that we will close soon.
Contributor
Author
There was a problem hiding this comment.
Thanks for letting me know! I left some comments in #44468 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
build/sbt "connect-client-jvm/testOnly *ClientE2ETestSuite"Was this patch authored or co-authored using generative AI tooling?
No