[SPARK-45967][BUILD] Upgrade jackson to 2.16.0 #43859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @pjfanning ~ Are there any issues that need special attention when upgrading to use Jackson 2.16.0? Thanks ~ |
panbingkun
commented
Nov 17, 2023
| @@ -1175,7 +1175,8 @@ class JsonFunctionsSuite extends QueryTest with SharedSparkSession { | |||
| val invalidDataType = "MAP<INT, cow>" | |||
| val invalidDataTypeReason = "Unrecognized token 'MAP': " + | |||
| "was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')\n " + | |||
| "at [Source: (String)\"MAP<INT, cow>\"; line: 1, column: 4]" | |||
| "at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); " + | |||
| "line: 1, column: 4]" | |||
panbingkun
commented
Nov 17, 2023
| @@ -1190,7 +1191,8 @@ class JsonFunctionsSuite extends QueryTest with SharedSparkSession { | |||
| val invalidTableSchema = "x INT, a cow" | |||
| val invalidTableSchemaReason = "Unrecognized token 'x': " + | |||
| "was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')\n" + | |||
| " at [Source: (String)\"x INT, a cow\"; line: 1, column: 2]" | |||
| " at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); " + | |||
| "line: 1, column: 2]" | |||
|
@LuciferYang it appears you are hitting some issues with tests but other than that, I don't expect significant issues. The changes are less significant than in 2.15.x. The StreamReadConstraints in 2.15.0 could affect real world users - see https://issues.apache.org/jira/browse/SPARK-42854 |
dongjoon-hyun
approved these changes
Nov 18, 2023
|
Thanks for your explain @pjfanning |
|
late LGTM |
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Aug 7, 2024
The pr aims to upgrade FasterXML jackson from 2.15.2 to 2.16.0. New version that fix some bugs, release notes as follows: - 2.1.6.0 https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.16, eg: [Databind](https://github.com/FasterXML/jackson-databind) [apache#1770](FasterXML/jackson-databind#1770): Incorrect deserialization for BigDecimal numbers - 2.15.3 https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.15.3, eg: [Databind](https://github.com/FasterXML/jackson-databind) [apache#3968](FasterXML/jackson-databind#3968): Records with additional constructors failed to deserialize The last upgrade occurred 6 months ago, apache#41414 No. Pass GA. No. Closes apache#43859 from panbingkun/SPARK-45967. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to upgrade FasterXML jackson from 2.15.2 to 2.16.0.
Why are the changes needed?
New version that fix some bugs, release notes as follows:
Databind #1770: Incorrect deserialization for BigDecimal numbers
Databind #3968: Records with additional constructors failed to deserialize
The last upgrade occurred 6 months ago, #41414
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.