[SPARK-46278][CONNECT][PS][TESTS] Re-organize GroupByTests
#44196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
itholic
changed the title
GroupByTestsGroupByTests
zhengruifeng
approved these changes
Dec 6, 2023
Contributor
|
merged to master |
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
### What changes were proposed in this pull request? This PR proposes to re-organize `GroupByTests`. ### Why are the changes needed? Break the big test file into small groups by topic such as Pandas does. ### Does this PR introduce _any_ user-facing change? No, it's test-only. ### How was this patch tested? The existing CI should pass with new structure of test files. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44196 from itholic/reorg_groupby_test. Authored-by: Haejoon Lee <haejoon.lee@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
HyukjinKwon
pushed a commit
that referenced
this pull request
Jan 7, 2024
### What changes were proposed in this pull request? 1, check the testing mode: - `test_assert_vanilla_mode` in `ReusedPySparkTestCase` - `test_assert_remote_mode` in `ReusedConnectTestCase` use different function names in case a test suite inherit them both 2, fix the incorrect testing mode introduced in #44196 ### Why are the changes needed? incorrect usage of `PandasOnSparkTestCase` (subclass of `ReusedPySparkTestCase`) in parity tests cause test with vanilla Spark Session: #44196 #44592 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? ci, added UT ### Was this patch authored or co-authored using generative AI tooling? no Closes #44611 from zhengruifeng/py_testing_mode. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to re-organize
GroupByTests.Why are the changes needed?
Break the big test file into small groups by topic such as Pandas does.
Does this PR introduce any user-facing change?
No, it's test-only.
How was this patch tested?
The existing CI should pass with new structure of test files.
Was this patch authored or co-authored using generative AI tooling?
No.