[SPARK-46544][SQL] Support v2 DESCRIBE TABLE EXTENDED with table stats #44535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Zouxxyy Please, trigger GitHub actions. |
MaxGekk
reviewed
Dec 30, 2023
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
Please, fix the failed test, seems it is related to your changes:
[info] == Results ==
[info] !== Correct Answer - 5 == == Spark Answer - 6 ==
[info] !struct<> struct<col_name:string,data_type:string,comment:string>
[info] [# Column Default Values,,] [# Column Default Values,,]
[info] [# Detailed Table Information,,] [# Detailed Table Information,,]
[info] [# Metadata Columns,,] [# Metadata Columns,,]
[info] ![id,bigint,42] [Statistics,0 bytes, 0 rows,null]
[info] ![id,bigint,null] [id,bigint,42]
[info] ! [id,bigint,null] (QueryTest.scala:267)
Contributor
Author
|
@MaxGekk Thanks for your reminder, fix it |
MaxGekk
requested changes
Jan 2, 2024
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/DescribeTableSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/DescribeTableSuite.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@MaxGekk Update, thanks |
MaxGekk
approved these changes
Jan 2, 2024
Member
|
+1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support v2 DESCRIBE TABLE EXTENDED with table stats
Why are the changes needed?
Similar to #40058, make DS v1/v2 command parity, e.g.
DESC EXTENDED table
Does this PR introduce any user-facing change?
No
How was this patch tested?
add test
describe extended table with statsWas this patch authored or co-authored using generative AI tooling?
No