[SPARK-46604][SQL] Make Literal.apply support s.c.immuable.ArraySeq
#44607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
commented
Jan 5, 2024
| val expected = toCatalyst(immArraySeq) | ||
| checkEvaluation(Literal(immArraySeq), expected) | ||
| checkEvaluation(Literal.create(immArraySeq), expected) | ||
| checkEvaluation(Literal.create(immArraySeq, ArrayType(DoubleType)), expected) |
Contributor
Author
There was a problem hiding this comment.
Even without this PR, the following two lines can pass the test successfully. These two lines are just to increase test coverage.
checkEvaluation(Literal.create(immArraySeq), expected)
checkEvaluation(Literal.create(immArraySeq, ArrayType(DoubleType)), expected)
dongjoon-hyun
approved these changes
Jan 6, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @LuciferYang .
Merged to master.
Contributor
Author
|
Thanks @dongjoon-hyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
Literal.createfunction supportsimmuable.ArraySeq, but theLiteral.applyfunction does not. So this pr make theLiteral.applyfunction to also supportimmuable.ArraySeq.Why are the changes needed?
Make
Literal.applysupports.c.immuable.ArraySeqasLiteral.createDoes this PR introduce any user-facing change?
Yes, user can create
Literalusing theLiteral.applyfunction withs.c.immuable.ArraySeqas input.How was this patch tested?
Add a new test
Was this patch authored or co-authored using generative AI tooling?
No