[SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter #44613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beliefer
changed the title
beliefer
changed the title
LuciferYang
reviewed
Jan 5, 2024
Contributor
There was a problem hiding this comment.
How about
private val dateTimeFormatter = DateTimeFormatter.ofPattern("yyyy/MM/dd HH:mm:ss", Locale.US)
.withZone(java.time.ZoneId.systemDefault())
def formatDate(date: Date): String = dateTimeFormatter.format(date.toInstant)
def formatDate(timestamp: Long): String = dateTimeFormatter.format(Instant.ofEpochMilli(timestamp))
Contributor
There was a problem hiding this comment.
This is even better than my suggestion, thanks @LuciferYang !
mridulm
reviewed
Jan 5, 2024
mridulm
reviewed
Jan 5, 2024
Contributor
mridulm
left a comment
mridulm
left a comment
There was a problem hiding this comment.
This is a nice change.
There are other usages of SimpleDateFormat which are candidates for this pattern.
Contributor
Author
I will check. |
beliefer
changed the title
Contributor
Author
|
ping @dongjoon-hyun @srowen cc @yaooqinn |
Member
|
I sent info about the spam from @llkj1 to GitHub support. |
Member
|
I tried to block the user and have been deleting the spam |
Contributor
|
is this one ready to go? |
Contributor
srowen
reviewed
Jan 8, 2024
| batchTimeFormat.get.setTimeZone(timezone) | ||
| batchTimeFormatWithMilliseconds.get.setTimeZone(timezone) | ||
| val zoneId = timezone.toZoneId | ||
| batchTimeFormat.withZone(zoneId) |
Contributor
Author
|
@LuciferYang @srowen @mridulm Thank you! |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jan 8, 2024
…one in UIUtils ### What changes were proposed in this pull request? Simplify code and fix new use of DateTimeFormat.withZone introduced in #44613 ; need to use the new object copy this creates. ### Why are the changes needed? Describing on mailing list from Janda Martin: ``` DateTimeFormatter is thread-safe and immutable according to JavaDoc so method DateTimeFormatter::withZone returns new instance when zone is changed. Following code has no effect: val oldTimezones = (batchTimeFormat.getZone, batchTimeFormatWithMilliseconds.getZone) if (timezone != null) { val zoneId = timezone.toZoneId batchTimeFormat.withZone(zoneId) batchTimeFormatWithMilliseconds.withZone(zoneId) } Suggested fix: introduce local variables for "batchTimeFormat" and "batchTimeFormatWithMilliseconds" and remove "oldTimezones" and "finally" block. ``` ### Does this PR introduce _any_ user-facing change? Unlikely, the path in question is apparently test-only ### How was this patch tested? Existing tests ### Was this patch authored or co-authored using generative AI tooling? No Closes #44619 from srowen/SPARK-46611.2. Authored-by: Sean Owen <srowen@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR propose to remove
ThreadLocalby replaceSimpleDateFormatwithDateTimeFormatter.Why are the changes needed?
SimpleDateFormatis not thread safe, so we wrap it withThreadLocal.DateTimeFormatteris thread safe, we can use it instead.According to the javadoc of
SimpleDateFormat, it recommended to useDateTimeFormattertoo.In addition,
DateTimeFormatterhave better performance thanSimpleDateFormattoo.Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA tests.
Was this patch authored or co-authored using generative AI tooling?
'No'.