Skip to content

[SPARK-46610][SQL] Create table should throw exception when no value for a key in options #44615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amaliujia wants to merge 4 commits into from
Closed

[SPARK-46610][SQL] Create table should throw exception when no value for a key in options #44615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37ab5aa
[SPARK-46610][SQL] Create table should throw exception when no value …
amaliujia Jan 6, 2024
32c1897
update
amaliujia Jan 6, 2024
617135b
Update sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/pars…
cloud-fan Jan 8, 2024
b625ea6
update
amaliujia Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3379,7 +3379,9 @@ class AstBuilder extends DataTypeAstBuilder with SQLConfHelper with Logging {
ctx: ExpressionPropertyListContext): OptionList = {
val options = ctx.expressionProperty.asScala.map { property =>
val key: String = visitPropertyKey(property.key)
val value: Expression = Option(property.value).map(expression).orNull
val value: Expression = Option(property.value).map(expression).getOrElse {
operationNotAllowed(s"A value must be specified for the key: $key.", ctx)
}
key -> value
}.toSeq
OptionList(options)
Expand Down
12 changes: 12 additions & 0 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2421,6 +2421,18 @@ class DDLParserSuite extends AnalysisTest {
stop = 42))
}

test("SPARK-46610: throw exception when no value for a key in create table options") {
val createTableSql = "create table test_table using my_data_source options (password)"
checkError(
exception = parseException(createTableSql),
errorClass = "_LEGACY_ERROR_TEMP_0035",
parameters = Map("message" -> "A value must be specified for the key: password."),
context = ExpectedContext(
fragment = createTableSql,
start = 0,
stop = 62))
}

test("UNCACHE TABLE") {
comparePlans(
parsePlan("UNCACHE TABLE a.b.c"),
Expand Down