Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR proposes to address null from Exception.getMessage in Py4J captured exception. It returns an empty string.

Why are the changes needed?

So whitelisted exceptions with an empty arguments are also covered.

Does this PR introduce any user-facing change?

Virtually no. It only happens when whitelisted exceptions are created without any argument so null is located in message.

How was this patch tested?

Manually.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the PYTHON label Jan 8, 2024
@HyukjinKwon
Copy link
Member Author

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@LuciferYang
Copy link
Contributor

@LuciferYang
Copy link
Contributor

Is this fix only for 4.0?

@LuciferYang
Copy link
Contributor

Merged into master. Thanks @HyukjinKwon

@HyukjinKwon
Copy link
Member Author

Yeah for 4.0 alone should be fine.

@HyukjinKwon
Copy link
Member Author

Thx!

@HyukjinKwon HyukjinKwon deleted the SPARK-46621 branch January 15, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants