[SPARK-46643][SQL][TESTS] Fix ORC tests to be independent from default compression #44648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Jan 10, 2024
| conf.setBoolean("hive.io.file.read.all.columns", false) | ||
|
|
||
| val orcRecordReader = { | ||
| val file = new File(path).listFiles().find(_.getName.endsWith(".snappy.orc")).head |
Member
Author
There was a problem hiding this comment.
This test case should be independent from the default codec, snappy.
HyukjinKwon
approved these changes
Jan 10, 2024
Member
Author
|
Thank you, @HyukjinKwon . These test case changes are tested manually. Let me merge this~ |
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Feb 7, 2024
…t compression This PR aims to fix ORC tests to be independent from the change of default ORC compression. Currently, a few test cases have implicit assumption. No. Pass the CIs. No. Closes apache#44648 from dongjoon-hyun/SPARK-46643. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix ORC tests to be independent from the change of default ORC compression.
Why are the changes needed?
Currently, a few test cases have implicit assumption.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.