[SPARK-46696][CORE] In ResourceProfileManager, function calls should occur after variable declarations

[lyy-pineapple]

What changes were proposed in this pull request?

In ResourceProfileManager, function calls should occur after variable declarations

Why are the changes needed?

As the title suggests, in ResourceProfileManager, function calls should be made after variable declarations. When determining isSupport, all variables are uninitialized, with booleans defaulting to false and objects to null. While the end result is correct, the evaluation process is abnormal.

Does this PR introduce any user-facing change?

No

How was this patch tested?

through exists uts

Was this patch authored or co-authored using generative AI tooling?

No

[mridulm]

Can you add a test to ensure this does not recur in future ?
+CC @tgravescs

[tgravescs]

change looks fine to me, thanks for fixing

[lyy-pineapple]

Can you add a test to ensure this does not recur in future ? +CC @tgravescs

Can you add a test to ensure this does not recur in future ? +CC @tgravescs

Adding tests can be challenging because all processes are within the initialization. To avoid this issue, we can add assert(master != null) in the function. Alternatively, consider changing the following variables to lazy val to ensure they are initialized before usage.I have chosen to include an assert statement here.

[lyy-pineapple]

@tgravescs @mridulm thanks for review, do you have any further comments？

[mridulm]

Merged to master.
Thanks for fixing this @lyy-pineapple !
Thanks for the review @tgravescs :-)