[SPARK-46739][SQL] Add the error class UNSUPPORTED_CALL
#44757
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
commented
Jan 16, 2024
| private[spark] object SparkUnsupportedOperationException { | ||
| def apply(): SparkUnsupportedOperationException = { | ||
| val stackTrace = Thread.currentThread().getStackTrace | ||
| val messageParameters = if (stackTrace.length >= 4) { |
Member
Author
There was a problem hiding this comment.
The stack trace looks like:
MaxGekk
changed the title
UNSUPPORTED_CALLUNSUPPORTED_CALL
MaxGekk
changed the title
UNSUPPORTED_CALLUNSUPPORTED_CALL
Member
Author
|
@cloud-fan @beliefer @LuciferYang @panbingkun Could you take a look at the PR, please. |
cloud-fan
approved these changes
Jan 17, 2024
Member
Author
|
Merging to master. Thank you, @cloud-fan for review. |
Contributor
|
late LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to add new error class for unsupported method calls, and remove similar legacy error classes. New
apply()method ofSparkUnsupportedOperationExceptionextracts method and class name from stack traces automatically, and places them to error class parameters.Why are the changes needed?
To improve code maintenance by avoid boilerplate code (extract class and method names automatically), and to clean up
error-classes.json.Does this PR introduce any user-facing change?
Yes, it can if user's code depends on the error class or message format of
SparkUnsupportedOperationException.How was this patch tested?
By running new test:
and the affected test suites:
Was this patch authored or co-authored using generative AI tooling?
No.