[SPARK-46754][SQL][AVRO] Fix compression code resolution in avro table definition and write options #44780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @dongjoon-hyun @cloud-fan, thank you in advance for reviewing this PR if you have some time. |
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroCodecSuite.scala
Outdated
Show resolved
Hide resolved
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroUtils.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
approved these changes
Jan 18, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. I have only one minor comment.
cloud-fan
approved these changes
Jan 18, 2024
Member
Author
|
Thank you @dongjoon-hyun and @cloud-fan, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the case sensitivity of 'compression' in the avro table definition and the write options, in order to make it consistent with other file sources. Also, the current logic for dealing invalid codec names is unreachable.
Why are the changes needed?
bugfix
Does this PR introduce any user-facing change?
yes, 'compression'='Xz', 'compression'='XZ' now works as well as 'compression'='xz'
How was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
no