[MINOR][DOCS] Add zstandard as a candidate to fix the desc of spark.sql.avro.compression.codec #44783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ql.avro.compression.codec
nchammas
approved these changes
Jan 18, 2024
| <td> | ||
| Compression codec used in writing of AVRO files. Supported codecs: uncompressed, deflate, | ||
| snappy, bzip2 and xz. Default codec is snappy. | ||
| snappy, bzip2, xz and zstandard. Default codec is snappy. |
Contributor
There was a problem hiding this comment.
I suggest also removing this bit as it duplicates the information in the default column.
Suggested change
| snappy, bzip2, xz and zstandard. Default codec is snappy. | |
| snappy, bzip2, xz and zstandard. |
Same here, of course:
dongjoon-hyun
approved these changes
Jan 18, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @yaooqinn .
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 18, 2024
…ql.avro.compression.codec ### What changes were proposed in this pull request? Add zstandard as a candidate to fix the desc of spark.sql.avro.compression.codec ### Why are the changes needed? docfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? doc build ### Was this patch authored or co-authored using generative AI tooling? no Closes #44783 from yaooqinn/avro_minor. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit c040824) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 18, 2024
…ql.avro.compression.codec ### What changes were proposed in this pull request? Add zstandard as a candidate to fix the desc of spark.sql.avro.compression.codec ### Why are the changes needed? docfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? doc build ### Was this patch authored or co-authored using generative AI tooling? no Closes #44783 from yaooqinn/avro_minor. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit c040824) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Member
|
Since it's supported since Spark 3.2.0 via SPARK-34479, I backported this to all live release branches. Merged to main/3.5/3.4. |
Member
Author
|
Thank @dongjoon-hyun @nchammas |
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Feb 7, 2024
…ql.avro.compression.codec ### What changes were proposed in this pull request? Add zstandard as a candidate to fix the desc of spark.sql.avro.compression.codec ### Why are the changes needed? docfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? doc build ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#44783 from yaooqinn/avro_minor. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit c040824) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add zstandard as a candidate to fix the desc of spark.sql.avro.compression.codec
Why are the changes needed?
docfix
Does this PR introduce any user-facing change?
no
How was this patch tested?
doc build
Was this patch authored or co-authored using generative AI tooling?
no