Skip to content

Conversation

@nchammas
Copy link
Contributor

What changes were proposed in this pull request?

Remove an unneeded method override in the definition of ProductionTag.

Why are the changes needed?

It's just noise.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

I built the docs and confirmed that this script block shows up only when PRODUCTION=1:

{% production %}
<!-- Matomo -->
<script>
var _paq = window._paq = window._paq || [];
/* tracker methods like "setCustomDimension" should be called before "trackPageView" */
_paq.push(["disableCookies"]);
_paq.push(['trackPageView']);
_paq.push(['enableLinkTracking']);
(function() {
var u="https://analytics.apache.org/";
_paq.push(['setTrackerUrl', u+'matomo.php']);
_paq.push(['setSiteId', '40']);
var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0];
g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s);
})();
</script>
<!-- End Matomo Code -->
{% endproduction %}

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the DOCS label Jan 18, 2024
@HyukjinKwon
Copy link
Member

Merged to master.

@nchammas nchammas deleted the production-tagblock branch January 19, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants