[SPARK-46773][BUILD][CONNECT] Change to use include-list to generate assemblyExcludedJars for the connect server module
#44798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
generate assemblyExcludedJars for the connect server modulegenerate assemblyExcludedJars for the connect server module
Contributor
Author
|
Test first |
dongjoon-hyun
approved these changes
Jan 19, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Looks reasonable if CI passes.
+1 (Pending CIs)
Member
|
Merged to master. |
Contributor
Author
|
Thanks @dongjoon-hyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr change to use include-list to generate
assemblyExcludedJarsoption for the connect server module to ensuresbt assemblyandmaven-shaded-pluginpackage the same jars. The reason for no longer using the exclude list is because it requires more configuration(There are over 40 additional jars that need to be excluded)Why are the changes needed?
Make
sbt assemblyandmaven-shaded-pluginpackage the same jarsDoes this PR introduce any user-facing change?
No
How was this patch tested?
sbt assembly.Was this patch authored or co-authored using generative AI tooling?
No