Skip to content

[SPARK-5714][Mllib] Refactor initial step of LDA to remove redundant operations #4501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
viirya wants to merge 2 commits into from
Closed

[SPARK-5714][Mllib] Refactor initial step of LDA to remove redundant operations #4501

viirya wants to merge 2 commits into from

Conversation

@viirya
Copy link
Member

@viirya viirya commented Feb 10, 2015

The initialState of LDA performs several RDD operations that looks redundant. This pr tries to simplify these operations.

@SparkQA
Copy link

SparkQA commented Feb 10, 2015

Test build #27193 has finished for PR 4501 at commit 9af1487.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Feb 10, 2015

an unrelated failure...

@viirya
Copy link
Member Author

viirya commented Feb 10, 2015

cc @jkbradley.

mengxr
mengxr reviewed Feb 10, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDA.scala Outdated
Copy link
Contributor

@mengxr mengxr Feb 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is val sum = gamma * edge.attr. We don't need axpy if the target vector does not exist.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27268 has finished for PR 4501 at commit 4870fe4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Feb 11, 2015

LGTM. Merged into master and branch-1.3. Thanks!

@asfgit asfgit closed this in f86a89a Feb 11, 2015
asfgit pushed a commit that referenced this pull request Feb 11, 2015
@viirya @mengxr
[SPARK-5714][Mllib] Refactor initial step of LDA to remove redundant …
ba3aa8f 
…operations

The `initialState` of LDA performs several RDD operations that looks redundant. This pr tries to simplify these operations.

Author: Liang-Chi Hsieh <viirya@gmail.com>

Closes #4501 from viirya/sim_lda and squashes the following commits:

4870fe4 [Liang-Chi Hsieh] For comments.
9af1487 [Liang-Chi Hsieh] Refactor initial step of LDA to remove redundant operations.

(cherry picked from commit f86a89a)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@viirya viirya deleted the sim_lda branch December 27, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@viirya @SparkQA @mengxr