Skip to content

[SPARK-5729] Potential NPE in standalone REST API #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andrewor14 wants to merge 1 commit into from
Closed

[SPARK-5729] Potential NPE in standalone REST API #4518

andrewor14 wants to merge 1 commit into from

Conversation

@andrewor14
Copy link
Contributor

@andrewor14 andrewor14 commented Feb 11, 2015

If the user specifies a bad REST URL, the server will throw an NPE instead of propagating the error back. This is because the default ErrorServlet has the wrong prefix. This is a one line fix. I am will add more comprehensive tests in a separate patch.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27259 has started for PR 4518 at commit 16b15bc.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27259 has finished for PR 4518 at commit 16b15bc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 11, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27259/
Test PASSed.

@pwendell
Copy link
Contributor

pwendell commented Feb 11, 2015

LGTM

@asfgit asfgit closed this in b969182 Feb 11, 2015
asfgit pushed a commit that referenced this pull request Feb 11, 2015
[SPARK-5729] Potential NPE in standalone REST API
1bc75b0 
If the user specifies a bad REST URL, the server will throw an NPE instead of propagating the error back. This is because the default `ErrorServlet` has the wrong prefix. This is a one line fix. I am will add more comprehensive tests in a separate patch.

Author: Andrew Or <andrew@databricks.com>

Closes #4518 from andrewor14/rest-npe and squashes the following commits:

16b15bc [Andrew Or] Correct ErrorServlet context prefix

(cherry picked from commit b969182)
Signed-off-by: Andrew Or <andrew@databricks.com>
@andrewor14 andrewor14 deleted the rest-npe branch February 11, 2015 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewor14 @SparkQA @AmplabJenkins @pwendell