[SPARK-42328][SQL] Remove _LEGACY_ERROR_TEMP_1175 from error classes #45183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Feb 20, 2024
MaxGekk
requested changes
Feb 21, 2024
| errorClass = "_LEGACY_ERROR_TEMP_1175", | ||
| messageParameters = Map("dataType" -> field.dataType.catalogString)) | ||
| errorClass = "UNSUPPORTED_DATATYPE", | ||
| messageParameters = Map("typeName" -> field.dataType.catalogString)) |
Member
There was a problem hiding this comment.
Could you quote the type using toSQLType() (the function uses slightly different converter of Catalyst type to strings. That's more consistent to other errors).
| } | ||
| checkError( | ||
| exception = intercept[AnalysisException] { | ||
| converter.convertField(StructField("test", dummyDataType)) |
Member
There was a problem hiding this comment.
Is it possible to reproduce the error using public API? If not, we should think of converting to an internal error.
Contributor
Author
There was a problem hiding this comment.
@MaxGekk Replaced it with INTERNAL_ERROR, please check the updated PR description.
MaxGekk
reviewed
Feb 21, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
…ompilationErrors.scala Co-authored-by: Maxim Gekk <max.gekk@gmail.com>
MaxGekk
approved these changes
Feb 22, 2024
Member
|
+1, LGTM. Merging to master. |
Member
|
@nikolamand-db Congratulations with your first contribution to Apache Spark! |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
### What changes were proposed in this pull request? Only occurrence of `_LEGACY_ERROR_TEMP_1175` appears under conversion from Spark data types to Parquet. All supported documented [Spark data types](https://spark.apache.org/docs/latest/sql-ref-datatypes.html) are covered in the [conversion function](https://github.com/apache/spark/blob/3e0808c33f185c13808ce2d547ce9ba0057d31a6/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala#L517-L745) (`VarcharType` and `CharType` are not present but they are passed down as string before reaching the conversion function), so under normal circumstances user can't force this error. Convert the error class to `INTERNAL_ERROR`. ### Why are the changes needed? Remove legacy error classes as part of activity in [SPARK-37935](https://issues.apache.org/jira/browse/SPARK-37935). ### Does this PR introduce _any_ user-facing change? If the Spark works correctly, user shouldn't be able to run into `INTERNAL_ERROR` by using the public API. ### How was this patch tested? Added test to `QueryCompilationErrorsSuite` and tested with sbt: ``` project sql testOnly *QueryCompilationErrorsSuite ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45183 from nikolamand-db/nikolamand-db/SPARK-42328. Authored-by: Nikola Mandic <nikola.mandic@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Only occurrence of
_LEGACY_ERROR_TEMP_1175appears under conversion from Spark data types to Parquet. All supported documented Spark data types are covered in the conversion function (VarcharTypeandCharTypeare not present but they are passed down as string before reaching the conversion function), so under normal circumstances user can't force this error.Convert the error class to
INTERNAL_ERROR.Why are the changes needed?
Remove legacy error classes as part of activity in SPARK-37935.
Does this PR introduce any user-facing change?
If the Spark works correctly, user shouldn't be able to run into
INTERNAL_ERRORby using the public API.How was this patch tested?
Added test to
QueryCompilationErrorsSuiteand tested with sbt:Was this patch authored or co-authored using generative AI tooling?
No.