[SPARK-47131][SQL][COLLATION] String function support: contains, startswith, endswith #45216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
changed the title
dbatomic
reviewed
Feb 22, 2024
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java
Outdated
Show resolved
Hide resolved
dbatomic
reviewed
Feb 22, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala
Outdated
Show resolved
Hide resolved
uros-db
changed the title
mitkedb
reviewed
Feb 22, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
Outdated
Show resolved
Hide resolved
uros-db
changed the title
dbatomic
reviewed
Feb 26, 2024
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
Outdated
Show resolved
Hide resolved
dbatomic
reviewed
Feb 26, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
Outdated
Show resolved
Hide resolved
dbatomic
reviewed
Feb 26, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
Outdated
Show resolved
Hide resolved
dbatomic
reviewed
Feb 26, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
Outdated
Show resolved
Hide resolved
dbatomic
reviewed
Feb 26, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala
Outdated
Show resolved
Hide resolved
uros-db
force-pushed
the
string-functions
branch
from
56d160c to
e0d51f4
Compare
uros-db
force-pushed
the
string-functions
branch
from
524f3da to
5c462a7
Compare
mkaravel
reviewed
Feb 28, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Feb 28, 2024
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
Outdated
Show resolved
Hide resolved
dbatomic
reviewed
Mar 1, 2024
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
Outdated
Show resolved
Hide resolved
dbatomic
reviewed
Mar 1, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
Outdated
Show resolved
Hide resolved
dbatomic
approved these changes
Mar 1, 2024
Contributor
dbatomic
left a comment
dbatomic
left a comment
There was a problem hiding this comment.
LGTM (plus a couple of minor comments).
cloud-fan
reviewed
Mar 1, 2024
cloud-fan
reviewed
Mar 1, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Mar 1, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Mar 1, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala
Outdated
Show resolved
Hide resolved
Contributor
|
@uros-db unfortunately it has code conflicts now |
cloud-fan
reviewed
Mar 4, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Mar 4, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
Show resolved
Hide resolved
cloud-fan
approved these changes
Mar 4, 2024
Contributor
|
thanks, merging to master! |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
…tswith, endswith ### What changes were proposed in this pull request? Refactor built-in string functions to support collation for: contains, startsWith, endsWith. ### Why are the changes needed? Add collation support for built-in string functions in Spark. ### Does this PR introduce _any_ user-facing change? Yes, users should now be able to use COLLATE within arguments for built-in string functions: CONTAINS, STARTSWITH, ENDSWITH in Spark SQL queries. ### How was this patch tested? Unit tests for: - string expressions (StringExpressionsSuite) - queries using "collate" (CollationSuite) ### Was this patch authored or co-authored using generative AI tooling? Yes. Closes apache#45216 from uros-db/string-functions. Authored-by: Uros Bojanic <157381213+uros-db@users.noreply.github.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor built-in string functions to support collation for: contains, startsWith, endsWith.
Why are the changes needed?
Add collation support for built-in string functions in Spark.
Does this PR introduce any user-facing change?
Yes, users should now be able to use COLLATE within arguments for built-in string functions: CONTAINS, STARTSWITH, ENDSWITH in Spark SQL queries.
How was this patch tested?
Unit tests for:
Was this patch authored or co-authored using generative AI tooling?
Yes.