Skip to content

Conversation

@panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Mar 6, 2024

What changes were proposed in this pull request?

The pr aims to fix flaky ParquetIOSuite, as follows:
https://github.com/panbingkun/spark/actions/runs/8167992505/job/22329299706
image

Why are the changes needed?

Only fix flaky UT ParquetIOSuite.

Through log analysis, the logic has reached the following point (possibly due to the timing of event processing):

sc.foreach(_.dagScheduler.stageFailed(stage, s"Authorized committer " +
s"(attemptNumber=$attemptNumber, stage=$stage, partition=$partition) failed; " +
s"but task commit success, data duplication may happen. " +
s"reason=$reason"))

new SparkException(s"Job aborted due to stage failure: $reason", cause = exception.orNull)

Does this PR introduce any user-facing change?

No.

How was this patch tested?

  • Manually test.
  • Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Mar 6, 2024
@panbingkun panbingkun marked this pull request as ready for review March 6, 2024 22:30
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@yaooqinn yaooqinn closed this in 0ff22b0 Mar 7, 2024
@yaooqinn
Copy link
Member

yaooqinn commented Mar 7, 2024

Merged to master.
Thank you, @panbingkun & @dongjoon-hyun

@cloud-fan
Copy link
Contributor

I think #46562 is a better fix, can we revert this workaround now?

@yaooqinn
Copy link
Member

+1 @cloud-fan

Since the LOCs have been moved to ParquetIOWithoutOutputCommitCoordinationSuite, we need a followup for reverting

@panbingkun
Copy link
Contributor Author

panbingkun commented May 14, 2024

+1 @cloud-fan

Since the LOCs have been moved to ParquetIOWithoutOutputCommitCoordinationSuite, we need a followup for reverting

Let me to do it.
#46577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants