[SPARK-47411][SQL] Support StringInstr & FindInSet functions to work with collated strings #45643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala
Show resolved
Hide resolved
miland-db
force-pushed
the
miland-db/substr-functions
branch
from
6a52d92 to
eb2d7c5
Compare
Contributor
Author
|
@cloud-fan @uros-db @mihailom-db can you take a look at this changes please? |
miland-db
changed the title
uros-db
reviewed
Mar 21, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Mar 25, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Mar 25, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Mar 25, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Mar 25, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Mar 25, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
miland-db
changed the title
uros-db
reviewed
Apr 15, 2024
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java
Show resolved
Hide resolved
uros-db
reviewed
Apr 15, 2024
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java
Outdated
Show resolved
Hide resolved
uros-db
reviewed
Apr 15, 2024
common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java
Show resolved
Hide resolved
uros-db
reviewed
Apr 15, 2024
common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java
Outdated
Show resolved
Hide resolved
uros-db
reviewed
Apr 15, 2024
common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java
Outdated
Show resolved
Hide resolved
uros-db
reviewed
Apr 15, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala
Show resolved
Hide resolved
uros-db
approved these changes
Apr 15, 2024
Contributor
uros-db
left a comment
uros-db
left a comment
There was a problem hiding this comment.
LGTM @cloud-fan please review
# Conflicts: # common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java # sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala
uros-db
reviewed
Apr 18, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala
Show resolved
Hide resolved
uros-db
reviewed
Apr 18, 2024
common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java
Show resolved
Hide resolved
uros-db
reviewed
Apr 18, 2024
common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java
Show resolved
Hide resolved
mihailomilosevic2001
approved these changes
Apr 22, 2024
Contributor
mihailomilosevic2001
left a comment
mihailomilosevic2001
left a comment
There was a problem hiding this comment.
LGTM, please change PR name to coincide with functions that you were implementing and with the JIRA ticket
miland-db
changed the title
cloud-fan
approved these changes
Apr 22, 2024
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extend built-in string functions to support non-binary, non-lowercase collation for: instr & find_in_set.
Why are the changes needed?
Update collation support for built-in string functions in Spark.
Does this PR introduce any user-facing change?
Yes, users should now be able to use COLLATE within arguments for built-in string functions INSTR and FIND_IN_SET in Spark SQL queries, using non-binary collations such as UNICODE_CI.
How was this patch tested?
Unit tests for queries using "collate" (CollationSuite).
Was this patch authored or co-authored using generative AI tooling?
No