[SPARK-47463][SQL][3.5] Use V2Predicate to wrap expression with return type of boolean #46074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n type of boolean
Member
Author
|
cc @cloud-fan |
Contributor
|
thanks, merging to 3.5! |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 18, 2024
…n type of boolean Backports #45589 to 3.5 ### What changes were proposed in this pull request? Use V2Predicate to wrap If expr when building v2 expressions. ### Why are the changes needed? The `PushFoldableIntoBranches` optimizer may fold predicate into (if / case) branches and `V2ExpressionBuilder` wraps `If` as `GeneralScalarExpression`, which causes the assertion in `PushablePredicate.unapply` to fail. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? added unit test ### Was this patch authored or co-authored using generative AI tooling? No Closes #46074 from wForget/SPARK-47463_3.5. Authored-by: Zhen Wang <643348094@qq.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
turboFei
pushed a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
…n type of boolean (apache#381) Backports apache#45589 to 3.5 ### What changes were proposed in this pull request? Use V2Predicate to wrap If expr when building v2 expressions. ### Why are the changes needed? The `PushFoldableIntoBranches` optimizer may fold predicate into (if / case) branches and `V2ExpressionBuilder` wraps `If` as `GeneralScalarExpression`, which causes the assertion in `PushablePredicate.unapply` to fail. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? added unit test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46074 from wForget/SPARK-47463_3.5. Authored-by: Zhen Wang <643348094@qq.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> Co-authored-by: Zhen Wang <643348094@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #45589 to 3.5
What changes were proposed in this pull request?
Use V2Predicate to wrap If expr when building v2 expressions.
Why are the changes needed?
The
PushFoldableIntoBranchesoptimizer may fold predicate into (if / case) branches andV2ExpressionBuilderwrapsIfasGeneralScalarExpression, which causes the assertion inPushablePredicate.unapplyto fail.Does this PR introduce any user-facing change?
No
How was this patch tested?
added unit test
Was this patch authored or co-authored using generative AI tooling?
No