Skip to content

[SPARK-48121][K8S] Promote KubernetesDriverConf to DeveloperApi #46373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jiangzho wants to merge 2 commits into from
Closed

[SPARK-48121][K8S] Promote KubernetesDriverConf to DeveloperApi #46373

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0323f27
[SPARK-48121][K8S]Promote `KubernetesDriverConf` to `DeveloperApi`
jiangzho May 3, 2024
95793f6
remove unintentional empty line
jiangzho May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import io.fabric8.kubernetes.api.model.{LocalObjectReference, LocalObjectReferen
import org.apache.commons.lang3.StringUtils

import org.apache.spark.{SPARK_VERSION, SparkConf}
import org.apache.spark.annotation.{DeveloperApi, Since, Unstable}
import org.apache.spark.deploy.k8s.Config._
import org.apache.spark.deploy.k8s.Constants._
import org.apache.spark.deploy.k8s.features.DriverServiceFeatureStep._
Expand Down Expand Up @@ -78,7 +79,15 @@ private[spark] abstract class KubernetesConf(val sparkConf: SparkConf) {
def getOption(key: String): Option[String] = sparkConf.getOption(key)
}

private[spark] class KubernetesDriverConf(
/**
* :: DeveloperApi ::
*
* Used for K8s operations internally and Spark K8s operator.
*/
@Unstable
@DeveloperApi
@Since("4.0.0")
Copy link
Member

@dongjoon-hyun dongjoon-hyun May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, I hope we can make it stable from 4.0.0.

class KubernetesDriverConf(
sparkConf: SparkConf,
val appId: String,
val mainAppResource: MainAppResource,
Expand Down