Skip to content

Conversation

@panbingkun
Copy link
Contributor

@panbingkun panbingkun commented May 14, 2024

What changes were proposed in this pull request?

This PR upgrades GenJavadoc plugin from 0.18 to 0.19.

Why are the changes needed?

1.The full release notes: https://github.com/lightbend/genjavadoc/releases/tag/v0.19

2.The latest version supports scala 2.13.14, which is a prerequisite for us to upgrade spark's scala 2.13.14.
https://mvnrepository.com/artifact/com.typesafe.genjavadoc/genjavadoc-plugin

3.The last upgrade occurred 3 years ago #33383

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Built the doc:

./build/sbt -Phadoop-3 -Pkubernetes -Pkinesis-asl -Phive-thriftserver -Pdocker-integration-tests -Pyarn -Phadoop-cloud -Pspark-ganglia-lgpl -Phive -Pjvm-profiler unidoc
image

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label May 14, 2024
@panbingkun panbingkun changed the title [Only Test] Test unidocGenjavadocVersion 0.19 [SPARK-48274][BUILD] Upgrade GenJavadoc to 0.19 May 14, 2024
@panbingkun panbingkun marked this pull request as ready for review May 14, 2024 14:23
@panbingkun
Copy link
Contributor Author

panbingkun commented May 14, 2024

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@LuciferYang
Copy link
Contributor

Merged into master for Spark 4.0. Thanks @panbingkun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants