[SPARK-48394][3.5][CORE] Cleanup mapIdToMapIndex on mapoutput unregister #46747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
#46749 should fix the issue in the build in this case. For now, you could rebase/force push and that should fix up the build |
This PR cleans up `mapIdToMapIndex` when the corresponding mapstatus is unregistered in three places: * `removeMapOutput` * `removeOutputsByFilter` * `addMapOutput` (old mapstatus overwritten) There is only one valid mapstatus for the same `mapIndex` at the same time in Spark. `mapIdToMapIndex` should also follows the same rule to avoid chaos. No. Unit tests. No. Closes #46706 from Ngone51/SPARK-43043-followup. Lead-authored-by: Yi Wu <yi.wu@databricks.com> Co-authored-by: wuyi <yi.wu@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Member
Author
|
It seems I mistakenly pushed the branch to apache repo rather than my own repo. Will remove that branch after the PR merged. |
Member
|
@Ngone51 the build won't trigger if the branch is in apache repo. Let's just open a new PR with your forked repository. |
Member
Author
|
@HyukjinKwon Oh, I see. Thanks for the reminder. |
Member
Author
|
FYI created a new PR (#46768) to replace this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports #46706 to branch 3.5.
What changes were proposed in this pull request?
This PR cleans up
mapIdToMapIndexwhen the corresponding mapstatus is unregistered in three places:removeMapOutputremoveOutputsByFilteraddMapOutput(old mapstatus overwritten)Why are the changes needed?
There is only one valid mapstatus for the same
mapIndexat the same time in Spark.mapIdToMapIndexshould also follows the same rule to avoid chaos.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.