Skip to content

[SPARK-48439][SQL] Derby: Calculate suitable precision and scale for DECIMAL type #46776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 1 commit into from
Closed

[SPARK-48439][SQL] Derby: Calculate suitable precision and scale for DECIMAL type #46776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions sql/core/src/main/scala/org/apache/spark/sql/jdbc/DerbyDialect.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,15 @@ private case class DerbyDialect() extends JdbcDialect {
case ByteType => Option(JdbcType("SMALLINT", java.sql.Types.SMALLINT))
case ShortType => Option(JdbcType("SMALLINT", java.sql.Types.SMALLINT))
case BooleanType => Option(JdbcType("BOOLEAN", java.sql.Types.BOOLEAN))
// 31 is the maximum precision and 5 is the default scale for a Derby DECIMAL
case t: DecimalType if t.precision > 31 =>
Option(JdbcType("DECIMAL(31,5)", java.sql.Types.DECIMAL))
// 31 is the maximum precision
// https://db.apache.org/derby/docs/10.13/ref/rrefsqlj15260.html
case t: DecimalType =>
val (p, s) = if (t.precision > 31) {
(31, math.max(t.scale - (t.precision - 31), 0))
} else {
(t.precision, t.scale)
}
Option(JdbcType(s"DECIMAL($p,$s)", java.sql.Types.DECIMAL))
case _ => None
}

Expand Down
8 changes: 8 additions & 0 deletions ...est/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/DerbyTableCatalogSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,12 @@ class DerbyTableCatalogSuite extends QueryTest with SharedSparkSession {
checkAnswer(sql(s"SHOW TABLES IN derby.test1"), Row("test1", "TABLE2", false))
}
}

test("SPARK-48439: Calculate suitable precision and scale for DECIMAL type") {
withTable("derby.test1.table1") {
sql("CREATE TABLE derby.test1.table1 (c1 decimal(38, 18))")
sql("INSERT INTO derby.test1.table1 VALUES (1.123456789123456789)")
checkAnswer(sql("SELECT * FROM derby.test1.table1"), Row(1.12345678912))
}
}
}