[SPARK-48557][SQL] Support scalar subquery with group-by on column equal to constant #46902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
agubichev
approved these changes
Jun 6, 2024
cloud-fan
reviewed
Jun 7, 2024
| val correlated = AttributeSet(splitConjunctivePredicates(cond) | ||
| .filter(containsOuter) // TODO: can remove this line to allow e.g. where x = 1 group by x | ||
| .filter( | ||
| SQLConf.get.getConf(SQLConf.SCALAR_SUBQUERY_ALLOW_GROUP_BY_COLUMN_EQUAL_TO_CONSTANT) |
Contributor
There was a problem hiding this comment.
I'm not sure we need this config and this restriction is newly added. It's OK to relax this un-released restriction.
Contributor
There was a problem hiding this comment.
Yea I think we can remove this config.
Contributor
Author
There was a problem hiding this comment.
Actually the restriction isn't new - it was there before for many years - so we are in fact adding newly supported query shapes.
So I added the config as per the usual flag any surface area change. Can remove it if we don't need it though.
allisonwang-db
approved these changes
Jun 14, 2024
| val correlated = AttributeSet(splitConjunctivePredicates(cond) | ||
| .filter(containsOuter) // TODO: can remove this line to allow e.g. where x = 1 group by x | ||
| .filter( | ||
| SQLConf.get.getConf(SQLConf.SCALAR_SUBQUERY_ALLOW_GROUP_BY_COLUMN_EQUAL_TO_CONSTANT) |
Contributor
There was a problem hiding this comment.
Yea I think we can remove this config.
cloud-fan
approved these changes
Jun 17, 2024
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We can enable scalar subqueries that have
group by aif there's a predicatea = 1, because these predicates guarantee the group-by produces at most one row. (This builds on top of #46839 and enables shapes there were unsupported prior to that PR as well.)Why are the changes needed?
Support valid subquery shapes.
Does this PR introduce any user-facing change?
Yes, support subquery shapes.
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No