Skip to content

[SPARK-48611][CORE] Log TID for input split in HadoopRDD and NewHadoopRDD #46966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pan3793 wants to merge 1 commit into from
Closed

[SPARK-48611][CORE] Log TID for input split in HadoopRDD and NewHadoopRDD #46966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,8 @@ class HadoopRDD[K, V](
val iter = new NextIterator[(K, V)] {

private val split = theSplit.asInstanceOf[HadoopPartition]
logInfo(log"Input split: ${MDC(INPUT_SPLIT, split.inputSplit)}")
logInfo(log"Task (TID ${MDC(TASK_ID, context.taskAttemptId())}) input split: " +
Copy link
Member

@gengliangwang gengliangwang Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use TASK_ATTEMPT_ID?

Copy link
Member Author

@pan3793 pan3793 Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

context.taskAttemptId() is task id, this was clarified in #45834 (comment)

log"${MDC(INPUT_SPLIT, split.inputSplit)}")
private val jobConf = getJobConf()

private val inputMetrics = context.taskMetrics().inputMetrics
Expand Down
3 changes: 2 additions & 1 deletion core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,8 @@ class NewHadoopRDD[K, V](
override def compute(theSplit: Partition, context: TaskContext): InterruptibleIterator[(K, V)] = {
val iter = new Iterator[(K, V)] {
private val split = theSplit.asInstanceOf[NewHadoopPartition]
logInfo(log"Input split: ${MDC(INPUT_SPLIT, split.serializableHadoopSplit)}")
logInfo(log"Task (TID ${MDC(TASK_ID, context.taskAttemptId())}) input split: " +
log"${MDC(INPUT_SPLIT, split.serializableHadoopSplit)}")
private val conf = getConf

private val inputMetrics = context.taskMetrics().inputMetrics
Expand Down