[SPARK-48683][SQL] Fix schema evolution with df.mergeInto losing when clauses
#47055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xupefei
changed the title
df.mergeInto losing when clausesdf.mergeInto losing when clauses
HyukjinKwon
approved these changes
Jun 24, 2024
|
Merged to master. |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…hen` clauses ### What changes were proposed in this pull request? This PR fixes an issue in the `DataFrame.mergeInto` API where defined `when` clauses are lost after calling the `withSchemaEvoltuion()` method. The issue is caused by not copying over existing clauses to the new writer. ### Why are the changes needed? It fixes a bug. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47055 from xupefei/mergeinto-bugfix. Authored-by: Paddy Xu <xupaddy@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes an issue in the
DataFrame.mergeIntoAPI where definedwhenclauses are lost after calling thewithSchemaEvoltuion()method.The issue is caused by not copying over existing clauses to the new writer.
Why are the changes needed?
It fixes a bug.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New test.
Was this patch authored or co-authored using generative AI tooling?
No.