[SPARK-48849][SS]Create OperatorStateMetadataV2 for the TransformWithStateExec operator #47445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…StateExec operator
jingz-db
reviewed
Jul 22, 2024
...n/scala/org/apache/spark/sql/execution/streaming/state/StateSchemaCompatibilityChecker.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala
Outdated
Show resolved
Hide resolved
...scala/org/apache/spark/sql/execution/datasources/v2/state/metadata/StateMetadataSource.scala
Show resolved
Hide resolved
...scala/org/apache/spark/sql/execution/datasources/v2/state/metadata/StateMetadataSource.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/OperatorStateMetadataLog.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala
Outdated
Show resolved
Hide resolved
...scala/org/apache/spark/sql/execution/datasources/v2/state/metadata/StateMetadataSource.scala
Outdated
Show resolved
Hide resolved
...n/scala/org/apache/spark/sql/execution/streaming/state/StateSchemaCompatibilityChecker.scala
Show resolved
Hide resolved
...n/scala/org/apache/spark/sql/execution/streaming/state/StateSchemaCompatibilityChecker.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala
Outdated
Show resolved
Hide resolved
...re/src/main/scala/org/apache/spark/sql/execution/streaming/state/OperatorStateMetadata.scala
Outdated
Show resolved
Hide resolved
...re/src/main/scala/org/apache/spark/sql/execution/streaming/state/OperatorStateMetadata.scala
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala
Outdated
Show resolved
Hide resolved
anishshri-db
approved these changes
Jul 23, 2024
Contributor
Author
|
@HeartSaVioR PTAL, thanks! |
HeartSaVioR
reviewed
Jul 24, 2024
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
First pass. Looks good in general.
...scala/org/apache/spark/sql/execution/datasources/v2/state/metadata/StateMetadataSource.scala
Show resolved
Hide resolved
...scala/org/apache/spark/sql/execution/datasources/v2/state/metadata/StateMetadataSource.scala
Outdated
Show resolved
Hide resolved
...scala/org/apache/spark/sql/execution/datasources/v2/state/metadata/StateMetadataSource.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala
Show resolved
Hide resolved
...n/scala/org/apache/spark/sql/execution/streaming/state/StateSchemaCompatibilityChecker.scala
Show resolved
Hide resolved
| * @param extraOptions - any extra options to be passed for StateStoreConf creation | ||
| * @param storeName - optional state store name | ||
| * @param schemaFilePath - optional schema file path | ||
| * @param oldSchemaFilePath - optional path to the old schema file. If not provided, will default |
Contributor
There was a problem hiding this comment.
Is it valid for schema version 3 to have None? Otherwise let's also mention here as same as below; Needed for schema version 3.
Contributor
Author
There was a problem hiding this comment.
Yeah, we don't expect there to be a schema file if we are in the first run of a new query, right?
...re/src/main/scala/org/apache/spark/sql/execution/streaming/state/OperatorStateMetadata.scala
Show resolved
Hide resolved
...re/src/main/scala/org/apache/spark/sql/execution/streaming/state/OperatorStateMetadata.scala
Outdated
Show resolved
Hide resolved
...re/src/main/scala/org/apache/spark/sql/execution/streaming/state/OperatorStateMetadata.scala
Outdated
Show resolved
Hide resolved
...re/src/main/scala/org/apache/spark/sql/execution/streaming/state/OperatorStateMetadata.scala
Outdated
Show resolved
Hide resolved
...scala/org/apache/spark/sql/execution/datasources/v2/state/metadata/StateMetadataSource.scala
Show resolved
Hide resolved
Contributor
Author
|
@HeartSaVioR addressed feedback, please take another look when you get a chance |
Contributor
|
Thanks! Merging to master. |
ilicmarkodb
pushed a commit
to ilicmarkodb/spark
that referenced
this pull request
Jul 29, 2024
…hStateExec operator ### What changes were proposed in this pull request? Introducing the OperatorStateMetadataV2 format that integrates with the TransformWithStateExec operator. This is used to keep information about the TWS operator, will be used to enforce invariants in between query runs. Each OperatorStateMetadataV2 has a pointer to the StateSchemaV3 file for the corresponding operator. Will introduce purging in this PR: apache#47286 ### Why are the changes needed? This is needed for State Metadata integration with the TransformWithState operator. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? Added unit tests to StateStoreSuite and TransformWithStateSuite ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47445 from ericm-db/metadata-v2. Authored-by: Eric Marnadi <eric.marnadi@databricks.com> Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introducing the OperatorStateMetadataV2 format that integrates with the TransformWithStateExec operator. This is used to keep information about the TWS operator, will be used to enforce invariants in between query runs. Each OperatorStateMetadataV2 has a pointer to the StateSchemaV3 file for the corresponding operator.
Will introduce purging in this PR: #47286
Why are the changes needed?
This is needed for State Metadata integration with the TransformWithState operator.
Does this PR introduce any user-facing change?
How was this patch tested?
Added unit tests to StateStoreSuite and TransformWithStateSuite
Was this patch authored or co-authored using generative AI tooling?
No