[SPARK-49071][SQL] Remove ArraySortLike trait #47547
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
In the PR title, instead of Cleanup SortArray, do you want to say Remove ArraySortLike trait, @ulysses-you ?
ulysses-you
changed the title
Contributor
Author
|
thank you @dongjoon-hyun, changed, also cc @yaooqinn |
yaooqinn
reviewed
Aug 1, 2024
...catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
Outdated
Show resolved
Hide resolved
yaooqinn
approved these changes
Aug 1, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Could you make the CI happy by fixing the style issue, @ulysses-you ?
HyukjinKwon
approved these changes
Aug 2, 2024
Contributor
Author
|
thank you @dongjoon-hyun @yaooqinn @HyukjinKwon , merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr cleanup the legacy code of
SortArrayto removeArraySortLikeand inlinenullOrder. TheArraySorthas been rewritten since #25728, so theSortArrayis the only implementation ofArraySortLike.Why are the changes needed?
cleanup the code
Does this PR introduce any user-facing change?
no
How was this patch tested?
Pass CI
Was this patch authored or co-authored using generative AI tooling?
no