Skip to content

[Minor] Fix doc typo for describing primitiveTerm effectiveness condition #4762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
viirya wants to merge 1 commit into from
Closed

[Minor] Fix doc typo for describing primitiveTerm effectiveness condition #4762

viirya wants to merge 1 commit into from

Conversation

@viirya
Copy link
Member

@viirya viirya commented Feb 25, 2015

It should be true instead of false?

@viirya viirya changed the title [Minor] Fix document type [Minor] Fix document typo Feb 25, 2015
@SparkQA
Copy link

SparkQA commented Feb 25, 2015

Test build #27945 has finished for PR 4762 at commit 2e37482.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Feb 25, 2015

I don't know enough to be sure if the change is right, but, I suggest the PR title be made more meaningful than "fix document typo' since it will become a commit message. I agree this does not necessarily need a JIRA.

@viirya viirya changed the title [Minor] Fix document typo [Minor] Fix doc typo for describing primitiveTerm validation condition Feb 25, 2015
@viirya
Copy link
Member Author

viirya commented Feb 25, 2015

@srowen Thanks. Using a more meaningful title now.

@viirya viirya changed the title [Minor] Fix doc typo for describing primitiveTerm validation condition [Minor] Fix doc typo for describing primitiveTerm effectiveness condition Feb 26, 2015
@viirya
Copy link
Member Author

viirya commented Feb 27, 2015

I think this is a minor one. Does anyone know if the change is correct? Thanks!

@srowen
Copy link
Member

srowen commented Mar 2, 2015

CC @marmbrus

@marmbrus
Copy link
Contributor

marmbrus commented Mar 2, 2015

Merged to master and 1.3

asfgit pushed a commit that referenced this pull request Mar 2, 2015
@viirya @marmbrus
[Minor] Fix doc typo for describing primitiveTerm effectiveness condi…
f92876a 
…tion

It should be `true` instead of `false`?

Author: Liang-Chi Hsieh <viirya@gmail.com>

Closes #4762 from viirya/doc_fix and squashes the following commits:

2e37482 [Liang-Chi Hsieh] Fix doc.

(cherry picked from commit 3f9def8)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in 3f9def8 Mar 2, 2015
@viirya viirya deleted the doc_fix branch December 27, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@viirya @SparkQA @srowen @marmbrus