Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-49335][BUILD] Upgrade Maven to 3.9.9 #47827

Closed
wants to merge 3 commits into from

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Aug 21, 2024

What changes were proposed in this pull request?

This PR aims to upgrade Maven to 3.9.9.

Why are the changes needed?

Release Note:

Bug Fixes:

  • MNG-8159 - Fix search for topDirectory when using -f / --file for Maven 3.9.x
  • MNG-8165 - Maven does not find extensions for -f when current dir is root
  • MNG-8177 - Warning "'dependencyManagement.dependencies.dependency.systemPath' for com.sun:tools:jar refers to a non-existing file C:\Temp\jdk-11.0.23..\lib\tools.jar"
  • MNG-8178 - Profile activation based on OS properties is broken for "mvn site"
  • MNG-8180 - Resolver will blindly assume it is deploying a plugin by presence of META-INF/maven/plugins.xml in JAR
  • MNG-8182 - Missing or mismatching Trusted Checksum for some artifacts is not properly reported
  • MNG-8188 - [REGRESSION] Property not resolved in profile pluginManagement

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@LuciferYang LuciferYang marked this pull request as draft August 21, 2024 09:13
@LuciferYang
Copy link
Contributor Author

Test first

@github-actions github-actions bot added the INFRA label Aug 21, 2024
@@ -306,6 +306,12 @@ jobs:
name: unit-tests-log-${{ matrix.modules }}-${{ matrix.comment }}-${{ matrix.java }}-${{ matrix.hadoop }}-${{ matrix.hive }}
path: "**/target/unit-tests.log"

maven-test:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert after test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot removed the INFRA label Aug 21, 2024
@LuciferYang LuciferYang marked this pull request as ready for review August 21, 2024 13:08
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@LuciferYang
Copy link
Contributor Author

Thanks @dongjoon-hyun

IvanK-db pushed a commit to IvanK-db/spark that referenced this pull request Sep 20, 2024
### What changes were proposed in this pull request?

This PR aims to upgrade Maven to 3.9.9.

### Why are the changes needed?

Release Note:
- https://maven.apache.org/docs/3.9.9/release-notes.html

    > Notable improvements in area of memory usage arrives with [Resolver 1.2.22](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12354902).

Bug Fixes:

- [MNG-8159](https://issues.apache.org/jira/browse/MNG-8159) - Fix search for topDirectory when using -f / --file for Maven 3.9.x
- [MNG-8165](https://issues.apache.org/jira/browse/MNG-8165) - Maven does not find extensions for -f when current dir is root
- [MNG-8177](https://issues.apache.org/jira/browse/MNG-8177) - Warning "'dependencyManagement.dependencies.dependency.systemPath' for com.sun:tools:jar refers to a non-existing file C:\Temp\jdk-11.0.23\..\lib\tools.jar"
- [MNG-8178](https://issues.apache.org/jira/browse/MNG-8178) - Profile activation based on OS properties is broken for "mvn site"
- [MNG-8180](https://issues.apache.org/jira/browse/MNG-8180) - Resolver will blindly assume it is deploying a plugin by presence of META-INF/maven/plugins.xml in JAR
- [MNG-8182](https://issues.apache.org/jira/browse/MNG-8182) - Missing or mismatching Trusted Checksum for some artifacts is not properly reported
- [MNG-8188](https://issues.apache.org/jira/browse/MNG-8188) - [REGRESSION] Property not resolved in profile pluginManagement

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#47827 from LuciferYang/SPARK-49335.

Authored-by: yangjie01 <yangjie01@baidu.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun added a commit to apache/orc that referenced this pull request Sep 30, 2024
### What changes were proposed in this pull request?

This PR aims to upgrade `Maven` to 3.9.9.

### Why are the changes needed?

To bring the latest bug fixed version in addition to align with Apache Spark 4.0.0,
- apache/spark#47827

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #2045 from dongjoon-hyun/ORC-1784.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun added a commit to apache/orc that referenced this pull request Sep 30, 2024
### What changes were proposed in this pull request?

This PR aims to upgrade `Maven` to 3.9.9.

### Why are the changes needed?

To bring the latest bug fixed version in addition to align with Apache Spark 4.0.0,
- apache/spark#47827

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #2045 from dongjoon-hyun/ORC-1784.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit b4982c9)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
### What changes were proposed in this pull request?

This PR aims to upgrade Maven to 3.9.9.

### Why are the changes needed?

Release Note:
- https://maven.apache.org/docs/3.9.9/release-notes.html

    > Notable improvements in area of memory usage arrives with [Resolver 1.2.22](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12354902).

Bug Fixes:

- [MNG-8159](https://issues.apache.org/jira/browse/MNG-8159) - Fix search for topDirectory when using -f / --file for Maven 3.9.x
- [MNG-8165](https://issues.apache.org/jira/browse/MNG-8165) - Maven does not find extensions for -f when current dir is root
- [MNG-8177](https://issues.apache.org/jira/browse/MNG-8177) - Warning "'dependencyManagement.dependencies.dependency.systemPath' for com.sun:tools:jar refers to a non-existing file C:\Temp\jdk-11.0.23\..\lib\tools.jar"
- [MNG-8178](https://issues.apache.org/jira/browse/MNG-8178) - Profile activation based on OS properties is broken for "mvn site"
- [MNG-8180](https://issues.apache.org/jira/browse/MNG-8180) - Resolver will blindly assume it is deploying a plugin by presence of META-INF/maven/plugins.xml in JAR
- [MNG-8182](https://issues.apache.org/jira/browse/MNG-8182) - Missing or mismatching Trusted Checksum for some artifacts is not properly reported
- [MNG-8188](https://issues.apache.org/jira/browse/MNG-8188) - [REGRESSION] Property not resolved in profile pluginManagement

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#47827 from LuciferYang/SPARK-49335.

Authored-by: yangjie01 <yangjie01@baidu.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
himadripal pushed a commit to himadripal/spark that referenced this pull request Oct 19, 2024
### What changes were proposed in this pull request?

This PR aims to upgrade Maven to 3.9.9.

### Why are the changes needed?

Release Note:
- https://maven.apache.org/docs/3.9.9/release-notes.html

    > Notable improvements in area of memory usage arrives with [Resolver 1.2.22](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12354902).

Bug Fixes:

- [MNG-8159](https://issues.apache.org/jira/browse/MNG-8159) - Fix search for topDirectory when using -f / --file for Maven 3.9.x
- [MNG-8165](https://issues.apache.org/jira/browse/MNG-8165) - Maven does not find extensions for -f when current dir is root
- [MNG-8177](https://issues.apache.org/jira/browse/MNG-8177) - Warning "'dependencyManagement.dependencies.dependency.systemPath' for com.sun:tools:jar refers to a non-existing file C:\Temp\jdk-11.0.23\..\lib\tools.jar"
- [MNG-8178](https://issues.apache.org/jira/browse/MNG-8178) - Profile activation based on OS properties is broken for "mvn site"
- [MNG-8180](https://issues.apache.org/jira/browse/MNG-8180) - Resolver will blindly assume it is deploying a plugin by presence of META-INF/maven/plugins.xml in JAR
- [MNG-8182](https://issues.apache.org/jira/browse/MNG-8182) - Missing or mismatching Trusted Checksum for some artifacts is not properly reported
- [MNG-8188](https://issues.apache.org/jira/browse/MNG-8188) - [REGRESSION] Property not resolved in profile pluginManagement

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#47827 from LuciferYang/SPARK-49335.

Authored-by: yangjie01 <yangjie01@baidu.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants