Skip to content

[SPARK-6036][CORE] avoid race condition between eventlogListener and akka actor system #4785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liyezhang556520 wants to merge 2 commits into from
Closed

[SPARK-6036][CORE] avoid race condition between eventlogListener and akka actor system #4785

liyezhang556520 wants to merge 2 commits into from

Conversation

@liyezhang556520
Copy link
Contributor

@liyezhang556520 liyezhang556520 commented Feb 26, 2015

For detail description, pls refer to SPARK-6036.

@liyezhang556520 liyezhang556520 changed the title SPARK-6036 avoid race condition between eventlogListener and akka actor system [SPARK-6036][CORE] avoid race condition between eventlogListener and akka actor system Feb 26, 2015
@SparkQA
Copy link

SparkQA commented Feb 26, 2015

Test build #27995 has finished for PR 4785 at commit 79b15b3.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Feb 26, 2015

Looks like a legit test failure in EventLoggingListenerSuite, hm. I think there may be a similar JIRA / PR for this, let me look.

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #28046 has finished for PR 4785 at commit 8b0b0a6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

andrewor14 commented Feb 27, 2015

I see, it was failing because we stopped the event logger before stopping the listener bus, which means we left out certain events like application end. Thanks I'm merging this into master, and marking it to be back ported later to 1.3 after the release.

@asfgit asfgit closed this in 8cd1692 Feb 27, 2015
@liyezhang556520
Copy link
Contributor Author

liyezhang556520 commented Feb 27, 2015

Thanks @srowen & @andrewor14

asfgit pushed a commit that referenced this pull request Mar 13, 2015
@liyezhang556520 @srowen
[SPARK-6036][CORE] avoid race condition between eventlogListener and …
f81611d 
…akka actor system

For detail description, pls refer to [SPARK-6036](https://issues.apache.org/jira/browse/SPARK-6036).

Author: Zhang, Liye <liye.zhang@intel.com>

Closes #4785 from liyezhang556520/EventLogInProcess and squashes the following commits:

8b0b0a6 [Zhang, Liye] stop listener after DAGScheduler
79b15b3 [Zhang, Liye] SPARK-6036 avoid race condition between eventlogListener and akka actor system
@liyezhang556520 liyezhang556520 deleted the EventLogInProcess branch April 28, 2015 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liyezhang556520 @SparkQA @srowen @andrewor14