SPARK-6045 RecordWriter should be checked against null in PairRDDFunctio...

[tedyu]

...ns#saveAsNewAPIHadoopDataset

[srowen]

Why check here? if it's null then this fails already in the loop. Just assert it's not null with require after it's obtained, if this is supposed to die in this case anyway.

[tedyu]

Thanks for the review, updated as suggested.

[AmplabJenkins]

Can one of the admins verify this patch?

[srowen]

There's no string interpolation here, and there is no actual NewRecordWriter class (it's an alias). Don't worry I can edit that before merge. I will have Jenkins test just for completeness

[srowen]

OK to test

[srowen]

Jenkins, test this please

[SparkQA]

Test build #28021 has started for PR 4794 at commit 2632a57.

• This patch merges cleanly.

[SparkQA]

Test build #28021 has finished for PR 4794 at commit 2632a57.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28021/
Test PASSed.

[srowen]

OK this looks like no-risk small fix. I'll adjust it and merge.