[SPARK-29474] [CORE] [WIP] CLI support for Spark-on-Docker-on-Yarn #48018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce four new command line arguments to spark-submit: ``` --yarn-docker-image --yarn-docker-mounts --executor-docker-image --executor-docker-mounts ``` Together, they can hide the boilerplate for using Docker on YARN: ```sh --conf spark.yarn.appMasterEnv.YARN_CONTAINER_RUNTIME_TYPE=docker --conf spark.yarn.appMasterEnv.YARN_CONTAINER_RUNTIME_DOCKER_IMAGE=repo/image:tag --conf spark.yarn.appMasterEnv.YARN_CONTAINER_RUNTIME_DOCKER_MOUNTS="/etc/passwd:/etc/passwd:ro,/etc/hadoop:/etc/hadoop:ro" --conf spark.executorEnv.YARN_CONTAINER_RUNTIME_TYPE=docker --conf spark.executorEnv.YARN_CONTAINER_RUNTIME_DOCKER_IMAGE=repo/image:tag --conf spark.executorEnv.YARN_CONTAINER_RUNTIME_DOCKER_MOUNTS="/etc/passwd:/etc/passwd:ro,/etc/hadoop:/etc/hadoop:ro" ``` Signed-off-by: Anne Macedo <annie@retpolanne.com>
|
Can you review, @gengliangwang, @LuciferYang @cloud-fan ? Thanks :) |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce four new command line arguments to spark-submit:
These arguments can be used to simplify the boilerplate code for using docker with YARN, such as:
Why are the changes needed?
The reasoning behind this change is this issue. It's important to have a more user friendly interface for using docker, instead of the boilerplate aforementioned, where spark/YARN configs for docker stay hidden behind a façade.
Does this PR introduce any user-facing change?
It adds the aforementioned command line arguments, that will be available on
spark-submitand subsequentlyspark-shellonce this PR is applied.How was this patch tested?
Tests were added, where it is tested if the configs from the boilerplace are properly applied. It was also tested using Github actions.
To do: test these changes on a real YARN cluster.
Was this patch authored or co-authored using generative AI tooling?
No.