-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-49656][SS] Add support for state variables with value state collection types and read change feed options #48148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd read change feed options
anishshri-db
changed the title
[SPARK-49656] Add support for state variables with value state collection types and read change feed options
[SPARK-49656][SS] Add support for state variables with value state collection types and read change feed options
Sep 18, 2024
cc - @jingz-db @HeartSaVioR - PTAL, thx ! |
anishshri-db
commented
Sep 19, 2024
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
Outdated
Show resolved
Hide resolved
HeartSaVioR
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass. Mostly style and suggestion for refactor.
...rc/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala
Outdated
Show resolved
Hide resolved
...rc/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala
Outdated
Show resolved
Hide resolved
...rc/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala
Outdated
Show resolved
Hide resolved
...rc/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala
Outdated
Show resolved
Hide resolved
HeartSaVioR
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks! Merging to master. |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…llection types and read change feed options ### What changes were proposed in this pull request? Add support for state variables with value state collection types and read change feed options ### Why are the changes needed? Without this, we cannot support reading per key changes for state variables used with stateful processors. ### Does this PR introduce _any_ user-facing change? Yes Users can now query value state variables with the following query: ``` val changeFeedDf = spark.read .format("statestore") .option(StateSourceOptions.PATH, <checkpoint_loc>) .option(StateSourceOptions.STATE_VAR_NAME, <state_var_name>) .option(StateSourceOptions.READ_CHANGE_FEED, true) .option(StateSourceOptions.CHANGE_START_BATCH_ID, 0) .load() ``` ### How was this patch tested? Added unit tests ``` [info] Run completed in 17 seconds, 318 milliseconds. [info] Total number of tests run: 2 [info] Suites: completed 1, aborted 0 [info] Tests: succeeded 2, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#48148 from anishshri-db/task/SPARK-49656. Authored-by: Anish Shrigondekar <anish.shrigondekar@databricks.com> Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…llection types and read change feed options ### What changes were proposed in this pull request? Add support for state variables with value state collection types and read change feed options ### Why are the changes needed? Without this, we cannot support reading per key changes for state variables used with stateful processors. ### Does this PR introduce _any_ user-facing change? Yes Users can now query value state variables with the following query: ``` val changeFeedDf = spark.read .format("statestore") .option(StateSourceOptions.PATH, <checkpoint_loc>) .option(StateSourceOptions.STATE_VAR_NAME, <state_var_name>) .option(StateSourceOptions.READ_CHANGE_FEED, true) .option(StateSourceOptions.CHANGE_START_BATCH_ID, 0) .load() ``` ### How was this patch tested? Added unit tests ``` [info] Run completed in 17 seconds, 318 milliseconds. [info] Total number of tests run: 2 [info] Suites: completed 1, aborted 0 [info] Tests: succeeded 2, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#48148 from anishshri-db/task/SPARK-49656. Authored-by: Anish Shrigondekar <anish.shrigondekar@databricks.com> Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add support for state variables with value state collection types and read change feed options
Why are the changes needed?
Without this, we cannot support reading per key changes for state variables used with stateful processors.
Does this PR introduce any user-facing change?
Yes
Users can now query value state variables with the following query:
How was this patch tested?
Added unit tests
Was this patch authored or co-authored using generative AI tooling?
No