[SPARK-49734][PYTHON] Add seed argument for function shuffle
#48184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Sep 20, 2024
| @@ -17723,7 +17723,7 @@ def array_sort( | |||
|
|
|||
|
|
|||
| @_try_remote_functions | |||
| def shuffle(col: "ColumnOrName") -> Column: | |||
| def shuffle(col: "ColumnOrName", seed: Optional[Union[Column, int]] = None) -> Column: | |||
There was a problem hiding this comment.
just curious, why do we want to support column type here?
There was a problem hiding this comment.
It's actually written on the top. e.g., in case we support seed as non-foldable expression in the future.
HyukjinKwon
reviewed
Sep 21, 2024
| * @group array_funcs | ||
| * @since 4.0.0 | ||
| */ | ||
| def shuffle(e: Column, seed: Long): Column = shuffle(e, lit(seed)) |
There was a problem hiding this comment.
I wouldn't actually add this in scala
There was a problem hiding this comment.
let me remove it
zhengruifeng
force-pushed
the
py_func_shuffle
branch
from
e8cee6c
to
2c1e130
Compare
|
merged to master |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? 1, Add `seed` argument for function `shuffle`; 2, Rewrite and enable the doctest by specify the seed and control the partitioning; ### Why are the changes needed? feature parity, seed is support in SQL side ### Does this PR introduce _any_ user-facing change? yes, new argument ### How was this patch tested? updated doctest ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#48184 from zhengruifeng/py_func_shuffle. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? 1, Add `seed` argument for function `shuffle`; 2, Rewrite and enable the doctest by specify the seed and control the partitioning; ### Why are the changes needed? feature parity, seed is support in SQL side ### Does this PR introduce _any_ user-facing change? yes, new argument ### How was this patch tested? updated doctest ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#48184 from zhengruifeng/py_func_shuffle. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, Add
seedargument for functionshuffle;2, Rewrite and enable the doctest by specify the seed and control the partitioning;
Why are the changes needed?
feature parity, seed is support in SQL side
Does this PR introduce any user-facing change?
yes, new argument
How was this patch tested?
updated doctest
Was this patch authored or co-authored using generative AI tooling?
no