-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-49774][BUILD] Upgrade guava to 33.3.1-jre #48233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| <!-- org.apache.commons/commons-pool2/--> | ||
| <commons-pool2.version>2.12.0</commons-pool2.version> | ||
| <datanucleus-core.version>4.1.17</datanucleus-core.version> | ||
| <guava.version>33.2.1-jre</guava.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After #42493, I think we should be able to unify it now ? @LuciferYang @pan3793 @dongjoon-hyun
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, IIRC, that was the proposal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I believe that we can continue to retain this configuration way, as it may be beneficial to allow the connect module to use an independent version of Guava.
This is just my personal opinion. We can also hear what others think or discuss it in the mail list
|
any update on this one @panbingkun |
| val guavaVersion = | ||
| SbtPomKeys.effectivePom.value.getProperties.get( | ||
| "guava.version").asInstanceOf[String] | ||
| "com.google.guava" % "guava" % guavaVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, how will the Guava version be resolved without this override?
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
What changes were proposed in this pull request?
The pr aims to
33.3.1-jreguava version, including:hive,connectanddocker integration testingWhy are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.