Skip to content

Conversation

@panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Sep 24, 2024

What changes were proposed in this pull request?

The pr aims to

  • upgrade guava to 33.3.1-jre
  • unified guava version, including: hive, connect and docker integration testing

Why are the changes needed?

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Sep 24, 2024
<!-- org.apache.commons/commons-pool2/-->
<commons-pool2.version>2.12.0</commons-pool2.version>
<datanucleus-core.version>4.1.17</datanucleus-core.version>
<guava.version>33.2.1-jre</guava.version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #42493, I think we should be able to unify it now ? @LuciferYang @pan3793 @dongjoon-hyun

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, IIRC, that was the proposal.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I believe that we can continue to retain this configuration way, as it may be beneficial to allow the connect module to use an independent version of Guava.

This is just my personal opinion. We can also hear what others think or discuss it in the mail list

@LuciferYang
Copy link
Contributor

any update on this one @panbingkun

val guavaVersion =
SbtPomKeys.effectivePom.value.getProperties.get(
"guava.version").asInstanceOf[String]
"com.google.guava" % "guava" % guavaVersion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, how will the Guava version be resolved without this override?

@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Jan 31, 2025
@github-actions github-actions bot closed this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants