Skip to content

Conversation

@exmy
Copy link
Contributor

@exmy exmy commented Oct 12, 2024

What changes were proposed in this pull request?

Find some code style issues for if/for/while statements

Why are the changes needed?

Fix code style for if/for/while statements

Does this PR introduce any user-facing change?

No

How was this patch tested?

N.A

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the SQL label Oct 12, 2024
Copy link
Member

@MaxGekk MaxGekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you are here, may I ask you to fix other places:

find . -name "*.scala" -print0|xargs -0 grep ' if('|wc -l
      39

@exmy exmy changed the title [MINOR] Fix code style in RuleIdCollection.scala [MINOR] Fix code style for if/for/while statements Nov 15, 2024
@exmy
Copy link
Contributor Author

exmy commented Nov 15, 2024

As you are here, may I ask you to fix other places:

find . -name "*.scala" -print0|xargs -0 grep ' if('|wc -l
      39

Sure, I've fixed the if style issue except if(isnull(fromExp), null, false) in sql, as well as for/while style issue.

@MaxGekk
Copy link
Member

MaxGekk commented Nov 15, 2024

+1, LGTM. Merging to master.
Thank you, @exmy.

@MaxGekk MaxGekk closed this in cf90271 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants