[SPARK-49942][SQL] Rename errorClass to condition in classifyException()
#48433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
errorClass to condition in JdbcDialect.classifyExceptionerrorClass to condition in JdbcDialect.classifyException
|
@cloud-fan @ivanjevtic-db @milastdbx Please, review this PR. I would like to rename it since the function haven't released yet. So, it is safe for now. |
|
LGTM. One question: Are we also going to rename |
| messageParameters: Map[String, String], | ||
| description: String, | ||
| isRuntime: Boolean): Throwable with SparkThrowable = { | ||
| if (isRuntime) { | ||
| new SparkRuntimeException( | ||
| errorClass = errorClass, | ||
| errorClass = condition, |
There was a problem hiding this comment.
Is there a plan to rename the errorClass argument to condition in SparkRuntimeException and AnalysisException?
Yep, let me rename it in the PR since it is related. |
MaxGekk
changed the title
errorClass to condition in JdbcDialect.classifyExceptionerrorClass to condition in classifyException()
ivanjevtic-db
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to rename the
errorClassparameter toconditioninJdbcDialect.classifyExceptionand inJdbcUtils.classifyException.Why are the changes needed?
To follow new naming convention introduced by #44902.
Does this PR introduce any user-facing change?
No. The
classifyExceptionmethod has not been released yet.How was this patch tested?
By running the existing GitHub actions.
Was this patch authored or co-authored using generative AI tooling?
No.