[SPARK-49948][PS][CONNECT] Add parameter "precision" to pandas on Spark box plot #48445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/pyspark/pandas/plot/core.py
Outdated
| precision: scalar, default = 0.01 | ||
| This argument is used by pandas-on-Spark to compute approximate statistics | ||
| for building a boxplot. Use *smaller* values to get more precise | ||
| statistics (matplotlib-only). | ||
| statistics (matplotlib-only).cccccbdvtdlhreffhieutnkglfeibhferhfctieuiiln |
There was a problem hiding this comment.
matplotlib-only
after this change, will it also take effect in plotly?
There was a problem hiding this comment.
I wasn’t sure why we added “matplotlib-only” in the first place, because it works with Plotly as shown here.
Removed.
zhengruifeng
approved these changes
Oct 15, 2024
|
Merged to master, thank you! |
| @@ -841,7 +841,7 @@ def barh(self, x=None, y=None, **kwargs): | |||
| elif isinstance(self.data, DataFrame): | |||
| return self(kind="barh", x=x, y=y, **kwargs) | |||
|
|
|||
| def box(self, **kwds): | |||
| def box(self, precision=0.01, **kwds): | |||
There was a problem hiding this comment.
on second thought, I think we'd better still hide precision in **kwds, because it is a spark-sepcific implementation details.
we can document it in under the **kwds docstring.
There was a problem hiding this comment.
That makes sense! Created https://issues.apache.org/jira/browse/SPARK-50001 for that.
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…rk box plot ### What changes were proposed in this pull request? Add parameter "precision" to pandas on Spark box plot. ### Why are the changes needed? Previously, the box method used **kwds, allowing precision to be passed implicitly. Now, adding precision directly to the signature ensures clarity and explicit control, improving usability. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48445 from xinrong-meng/ps_box. Authored-by: Xinrong Meng <xinrong@apache.org> Signed-off-by: Xinrong Meng <xinrong@apache.org>
xinrong-meng
added a commit
that referenced
this pull request
Oct 21, 2024
…wargs for box plots ### What changes were proposed in this pull request? Adjust "precision" to be kwargs for box plots in both Pandas on Spark and PySpark. ### Why are the changes needed? Per discussion here (#48445 (comment)), precision is Spark-specific implementation detail, so we wanted to keep “precision” as part of kwargs for box plots. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48513 from xinrong-meng/precision. Authored-by: Xinrong Meng <xinrong@apache.org> Signed-off-by: Xinrong Meng <xinrong@apache.org>
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Oct 22, 2024
…wargs for box plots ### What changes were proposed in this pull request? Adjust "precision" to be kwargs for box plots in both Pandas on Spark and PySpark. ### Why are the changes needed? Per discussion here (apache#48445 (comment)), precision is Spark-specific implementation detail, so we wanted to keep “precision” as part of kwargs for box plots. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48513 from xinrong-meng/precision. Authored-by: Xinrong Meng <xinrong@apache.org> Signed-off-by: Xinrong Meng <xinrong@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add parameter "precision" to pandas on Spark box plot.
Why are the changes needed?
Previously, the box method used **kwds, allowing precision to be passed implicitly. Now, adding precision directly to the signature ensures clarity and explicit control, improving usability.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.