[SPARK-50049][SQL] Support custom driver metrics in writing to v2 table #48573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
Author
|
gentle ping @viirya @cloud-fan for review. |
cloud-fan
reviewed
Nov 14, 2024
...ore/src/test/scala/org/apache/spark/sql/execution/datasources/InMemoryTableMetricSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Nov 14, 2024
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/Write.java
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Nov 14, 2024
cloud-fan
reviewed
Nov 14, 2024
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/Write.java
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Nov 14, 2024
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/Write.java
Outdated
Show resolved
Hide resolved
Contributor
|
@manuzhang can you rebase with the latest master and re-trigger the CI? |
…rces/InMemoryTableMetricSuite.scala
manuzhang
force-pushed
the
v2write-metrics
branch
from
3ffbf19 to
98e8e4c
Compare
Member
Author
|
@cloud-fan Done! |
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
reportDriverMetricsmethod toWriteAPI and post custom metrics from driver after v2 write commits.Why are the changes needed?
Does this PR introduce any user-facing change?
#37205 supported reporting custom driver metrics when reading from v2 table. This is to support that when writing to v2 table.
How was this patch tested?
UT.
Was this patch authored or co-authored using generative AI tooling?
No.