Skip to content

[SPARK-6121][SQL][MLLIB] simpleString for UDT #4858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mengxr wants to merge 1 commit into from
Closed

[SPARK-6121][SQL][MLLIB] simpleString for UDT #4858

mengxr wants to merge 1 commit into from

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Mar 2, 2015

df.dtypes shows null for UDTs. This PR uses udt by default and VectorUDT overwrites it with vector.

@jkbradley @davies

@SparkQA
Copy link

SparkQA commented Mar 2, 2015

Test build #28197 has started for PR 4858 at commit 34f0a77.

  • This patch merges cleanly.

@davies
Copy link
Contributor

davies commented Mar 2, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Mar 3, 2015

Test build #28197 has finished for PR 4858 at commit 34f0a77.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 3, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28197/
Test PASSed.

@jkbradley
Copy link
Member

jkbradley commented Mar 3, 2015

Trying to recall where this is used: Is this used in serialization? Will it cause problems with users who saved RDDs in a previous Spark version and want to re-load them in 1.3?

If not, LGTM

@marmbrus
Copy link
Contributor

marmbrus commented Mar 3, 2015

I think that only the JSON representation of datatypes is used for serialization.

@mengxr
Copy link
Contributor Author

mengxr commented Mar 3, 2015

Merged into master and branch-1.3. Thanks!

@asfgit asfgit closed this in 2db6a85 Mar 3, 2015
asfgit pushed a commit that referenced this pull request Mar 3, 2015
@mengxr
[SPARK-6121][SQL][MLLIB] simpleString for UDT
1b8ab57 
`df.dtypes` shows `null` for UDTs. This PR uses `udt` by default and `VectorUDT` overwrites it with `vector`.

jkbradley davies

Author: Xiangrui Meng <meng@databricks.com>

Closes #4858 from mengxr/SPARK-6121 and squashes the following commits:

34f0a77 [Xiangrui Meng] simpleString for UDT

(cherry picked from commit 2db6a85)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mengxr @SparkQA @davies @AmplabJenkins @jkbradley @marmbrus