Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs #48611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wayneguow
Copy link
Contributor

What changes were proposed in this pull request?

This PR aims to remove some unnecessary Jersey-related warning logs when ApiRootResource or PrometheusResource api was called.

To reproduce, when we start spark-shell with the latest master code, open the Spark UI, click the executor tab, you can see relevant warning logs appearing in the spark-shell.

image

image

There are some related pr and issues about jersey:

And we can solve these warning logs by setting some properties.

Why are the changes needed?

Remove unnecessary warning logs.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manual check. After this pr, the warning logs are removed.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the CORE label Oct 23, 2024
@LuciferYang
Copy link
Contributor

LuciferYang commented Oct 23, 2024

cc @pan3793 and @dongjoon-hyun FYI

@LuciferYang
Copy link
Contributor

also cc @panbingkun

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, @wayneguow . I also observed the issue.

Since this is a log-related thing, it seems a little hard to validate.

Could you revise your PR description about how to validate the contributions on the followings from their logs?

  • All Spark shell environments (spark-shell, spark-sql, pyspark, sparkR) are fixed?
  • Spark Deamons (Spark Master/Worker/HistoryServer) are fixed?
  • Spark Applications on Spark Standalone Cluster and K9s Cluster (at least)?

@LuciferYang
Copy link
Contributor

Are there any negative impacts of disabling these features? Is it possible to retain these features through upgrading dependencies or code changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants