Skip to content

[SPARK-6134][SQL] Fix wrong datatype for casting FloatType and default LongType value in defaultPrimitive #4870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
viirya wants to merge 1 commit into from
Closed

[SPARK-6134][SQL] Fix wrong datatype for casting FloatType and default LongType value in defaultPrimitive #4870

viirya wants to merge 1 commit into from

Conversation

@viirya
Copy link
Member

@viirya viirya commented Mar 3, 2015

In CodeGenerator, the casting on FloatType should use FloatType instead of IntegerType.

Besides, defaultPrimitive for LongType should be -1L instead of 1L.

@viirya
Copy link
Member Author

viirya commented Mar 3, 2015

CC @marmbrus.

@SparkQA
Copy link

SparkQA commented Mar 3, 2015

Test build #28226 has finished for PR 4870 at commit 76311dd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@chenghao-intel
Copy link
Contributor

chenghao-intel commented Mar 3, 2015

Good catch, LGTM.

@adrian-wang
Copy link
Contributor

adrian-wang commented Mar 4, 2015

LGTM

@liancheng
Copy link
Contributor

liancheng commented Mar 4, 2015

LGTM, merging into master and branch-1.3. Thanks!

@asfgit asfgit closed this in aef8a84 Mar 4, 2015
asfgit pushed a commit that referenced this pull request Mar 4, 2015
@viirya @liancheng
[SPARK-6134][SQL] Fix wrong datatype for casting FloatType and defaul…
bfa4e31 
…t LongType value in defaultPrimitive

In `CodeGenerator`, the casting on `FloatType` should use `FloatType` instead of `IntegerType`.

Besides, `defaultPrimitive` for `LongType` should be `-1L` instead of `1L`.

Author: Liang-Chi Hsieh <viirya@gmail.com>

Closes #4870 from viirya/codegen_type and squashes the following commits:

76311dd [Liang-Chi Hsieh] Fix wrong datatype for casting on FloatType. Fix the wrong value for LongType in defaultPrimitive.

(cherry picked from commit aef8a84)
Signed-off-by: Cheng Lian <lian@databricks.com>
@viirya viirya deleted the codegen_type branch December 27, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@viirya @SparkQA @chenghao-intel @adrian-wang @liancheng