Skip to content

SPARK-1911 [DOCS] Warn users if their assembly jars are not built with Java 6 #4874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srowen wants to merge 1 commit into from
Closed

SPARK-1911 [DOCS] Warn users if their assembly jars are not built with Java 6 #4874

srowen wants to merge 1 commit into from

Conversation

@srowen
Copy link
Member

@srowen srowen commented Mar 3, 2015

Add warning about building with Java 7+ and running the JAR on early Java 6.

CC @andrewor14

@SparkQA
Copy link

SparkQA commented Mar 3, 2015

Test build #28233 has started for PR 4874 at commit 79fa2f6.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 3, 2015

Test build #28233 has finished for PR 4874 at commit 79fa2f6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 3, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28233/
Test PASSed.

vanzin
vanzin reviewed Mar 3, 2015
View reviewed changes
docs/building-spark.md
Copy link
Contributor

@vanzin vanzin Mar 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "or later" part is not true, I think. I remember testing that JDK7 is the problem: jars with > 65k files created on JDK7 won't work on either JDK6 or JDK8 (!). Jars created with anything but JDK7 seem to work everywhere.

Copy link
Contributor

@vanzin vanzin Mar 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind me. Just ran some quick tests and it seems your warning is accurate.

@asfgit asfgit closed this in e750a6b Mar 3, 2015
asfgit pushed a commit that referenced this pull request Mar 3, 2015
@srowen
SPARK-1911 [DOCS] Warn users if their assembly jars are not built wit…
8446ad0 
…h Java 6

Add warning about building with Java 7+ and running the JAR on early Java 6.

CC andrewor14

Author: Sean Owen <sowen@cloudera.com>

Closes #4874 from srowen/SPARK-1911 and squashes the following commits:

79fa2f6 [Sean Owen] Add warning about building with Java 7+ and running the JAR on early Java 6.

(cherry picked from commit e750a6b)
Signed-off-by: Andrew Or <andrew@databricks.com>
@andrewor14
Copy link
Contributor

andrewor14 commented Mar 3, 2015

Yeah, LGTM I'm surprised this is not already documented. Merging into master and 1.3. There were some conflicts to merge this into older branches, so feel free to open this PR against those branches.

@srowen srowen deleted the SPARK-1911 branch March 4, 2015 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@srowen @SparkQA @AmplabJenkins @andrewor14 @vanzin